refactor(storage): deprecate preserve_acl arg in copy_blob() method#104
Merged
frankyn merged 6 commits intogoogleapis:masterfrom Apr 20, 2020
Merged
Conversation
IlyaFaer
commented
Apr 13, 2020
IlyaFaer
commented
Apr 13, 2020
Author
As for the feature for copying ACLs, I suppose, we could use |
frankyn
suggested changes
Apr 16, 2020
…method" This reverts commit edd0137.
…/python-storage into preserve_acl_deprecation
frankyn
approved these changes
Apr 17, 2020
Contributor
frankyn
left a comment
There was a problem hiding this comment.
LGTM, thanks for adding the example.
cojenco
pushed a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
…oogleapis#104) * refactor(storage): deprecate preserve_acl arg in copy_blob() method * Revert "refactor(storage): deprecate preserve_acl arg in copy_blob() method" This reverts commit edd0137. * add deprecation warning into docs, provide a snippet of how to copy ACL Co-authored-by: Frank Natividad <[email protected]>
cojenco
pushed a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
…oogleapis#104) * refactor(storage): deprecate preserve_acl arg in copy_blob() method * Revert "refactor(storage): deprecate preserve_acl arg in copy_blob() method" This reverts commit edd0137. * add deprecation warning into docs, provide a snippet of how to copy ACL Co-authored-by: Frank Natividad <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #37